Messages in this thread | | | From | "Mukker, Atul" <> | Subject | RE: [ANNOUNCE][RELEASE]: megaraid unified driver version 2.20.0.B 1 | Date | Fri, 9 Apr 2004 00:05:49 -0400 |
| |
>OK, I have started to look at this driver, I have come across one Good!
>problem, which the attached patch fixes. This patch has been sent >through the list several times and has been accepted into 2.6.5. Taken, would be added asap
>1. The Kconfig.megaraid and Makefile.2.6 files from the alpha release >are not in the beta. Will be added in next drop
>2. In mraid_pci_blk_pool_destroy(), the caller "guarantees that no more >memory from the pool is in use", however, they don't have to guarantee >that pool is not null. Why? In fact, in the code it appears that this >guarantee is also made... Now you are reading between the lines :-) Just consider clib to be independently implemented and has some safety checks
>3. I am not sure what the local conventions on this are, but in >megaraid_alloc_cmd_packets() if the first allocation fails then we >return straight away, in all other cases we do a goto fail_alloc_cmds; Accepted..
>4. Also a consistency issue: In megaraid_mbox_mm_cmd() we handle the >deletion of a logical drive specially, by calling >megaraid_mbox_del_logdrv(), which just ensures that the drives are Good catch.
Thanks! -Atul Mukker LSI Logic - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |