Messages in this thread Patch in this message | | | Date | Fri, 30 Apr 2004 16:44:40 -0500 | From | Matt Domsch <> | Subject | Re: reduce blk queue and I/O capability printk to KERN_DEBUG? |
| |
On Fri, Apr 30, 2004 at 04:28:37PM -0500, Matt Domsch wrote: > On Fri, Apr 30, 2004 at 11:13:43PM +0200, Jens Axboe wrote: > > It should just be deleted. As you note, it is a debug message. I > > originally added it so we would have some clues as to dma capability for > > bug reports. There never was any, the check can go :)
Second try, let's remove the unused variables.
Please ack the below for Andrew then. Likewise for 2.4 please?
Remove blk: queue xxxx I/O limit xxxx messages printed by all block devices
This was a debug message and is no longer needed.
===== drivers/block/ll_rw_blk.c 1.244 vs edited ===== --- 1.244/drivers/block/ll_rw_blk.c Tue Apr 27 08:11:32 2004 +++ edited/drivers/block/ll_rw_blk.c Fri Apr 30 16:38:52 2004 @@ -265,8 +265,6 @@ void blk_queue_bounce_limit(request_queue_t *q, u64 dma_addr) { unsigned long bounce_pfn = dma_addr >> PAGE_SHIFT; - unsigned long mb = dma_addr >> 20; - static request_queue_t *last_q; /* * set appropriate bounce gfp mask -- unfortunately we don't have a @@ -280,19 +278,7 @@ } else q->bounce_gfp = GFP_NOIO; - /* - * keep this for debugging for now... - */ - if (dma_addr != BLK_BOUNCE_HIGH && q != last_q) { - printk("blk: queue %p, ", q); - if (dma_addr == BLK_BOUNCE_ANY) - printk("no I/O memory limit\n"); - else - printk("I/O limit %luMb (mask 0x%Lx)\n", mb, (long long) dma_addr); - } - q->bounce_pfn = bounce_pfn; - last_q = q; } EXPORT_SYMBOL(blk_queue_bounce_limit);[unhandled content-type:application/pgp-signature] | |