Messages in this thread | | | Date | Fri, 30 Apr 2004 23:13:43 +0200 | From | Jens Axboe <> | Subject | Re: reduce blk queue and I/O capability printk to KERN_DEBUG? |
| |
On Fri, Apr 30 2004, Matt Domsch wrote: > Jens, > > Any reason why this message isn't being printed at KERN_DEBUG or > thereabouts, as the comment immediately before it notes it's for > debugging purposes, and it's only interesting to kernel developers not > end users? > > Thanks, > Matt > > -- > Matt Domsch > Sr. Software Engineer, Lead Engineer > Dell Linux Solutions linux.dell.com & www.dell.com/linux > Linux on Dell mailing lists @ http://lists.us.dell.com > > ===== drivers/block/ll_rw_blk.c 1.244 vs edited ===== > --- 1.244/drivers/block/ll_rw_blk.c Tue Apr 27 08:11:32 2004 > +++ edited/drivers/block/ll_rw_blk.c Fri Apr 30 14:46:57 2004 > @@ -284,7 +284,7 @@ > * keep this for debugging for now... > */ > if (dma_addr != BLK_BOUNCE_HIGH && q != last_q) { > - printk("blk: queue %p, ", q); > + printk(KERN_DEBUG "blk: queue %p, ", q); > if (dma_addr == BLK_BOUNCE_ANY) > printk("no I/O memory limit\n"); > else
It should just be deleted. As you note, it is a debug message. I originally added it so we would have some clues as to dma capability for bug reports. There never was any, the check can go :)
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |