Messages in this thread Patch in this message | | | Subject | Re: [PATCH] Blacklist binary-only modules lying about their license | From | Valdis.Kletnieks@vt ... | Date | Tue, 27 Apr 2004 16:18:42 -0400 |
| |
On Tue, 27 Apr 2004 21:41:51 +0200, "Jorge Bernal (Koke)" said:
> 2 ideas: > > Printing if the tainted module is loaded or unloaded
We already have a message when it's loading, and a message on unload is superfluous - if I insmod the NVidia driver and then unload it, the kernel is still tainted by it, because it had a chance to mangle memory while it was loaded.
And yes, sometimes the damage can be hiding for a LONG time - I know I've seen bug reports on the list that involved "module A dorked a pointer which wasn't noticed for 3 days until module B tried to...."
Would the attached strawman patch make people happ(y|ier)?
--- linux-2.6.6-rc2-mm2/kernel/module.c.orig 2004-04-27 09:56:22.000000000 -0400 +++ linux-2.6.6-rc2-mm2/kernel/module.c 2004-04-27 16:16:59.764158885 -0400 @@ -1131,7 +1131,7 @@ static void set_license(struct module *m mod->license_gplok = license_is_gpl_compatible(license); if (!mod->license_gplok) { - printk(KERN_WARNING "%s: module license '%s' taints kernel.\n", + printk(KERN_NOTICE "%s: module license '%s' taints kernel.\n", mod->name, license); tainted |= TAINT_PROPRIETARY_MODULE; }
[unhandled content-type:application/pgp-signature] | |