Messages in this thread | | | Subject | Re: Large inlines in include/linux/skbuff.h | From | Andi Kleen <> | Date | Thu, 22 Apr 2004 16:59:41 +0200 |
| |
James Morris <jmorris@redhat.com> writes:
> On Wed, 21 Apr 2004, Denis Vlasenko wrote: > >> What shall be done with this? I'll make patch to move locking functions >> into net/core/skbuff.c unless there is some reason not to do it. > > How will these changes impact performance? I asked this last time you > posted about inlines and didn't see any response.
I don't think it will be an issue. The optimization guidelines of AMD and Intel recommend to move functions that generate more than 30-40 instructions out of line. 100 instructions is certainly enough to amortize the call overhead, and you safe some icache too so it may be even faster.
-Andi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |