Messages in this thread | | | Subject | Re: [PATCH] s390 (9/9): no timer interrupts in idle. | From | Martin Schwidefsky <> | Date | Wed, 21 Apr 2004 18:31:08 +0200 |
| |
Hi Christoph,
> > +static inline void rcu_set_active_cpu_map(cpumask_t *mask) > > +{ > > + cpumask_t active = idle_cpu_mask; > > + cpus_complement(active); > > + cpus_and(*mask, cpu_online_map, active); > > +} > > This is a bit ugly. What about inlining the CONFIG_NO_IDLE_HZ case > of this function in it's only caller and define idle_cpu_mask to > an empty cpu mask for all other arches?
This would mean that all other arches need to do the above three statements in rcu_start_batch. If this is acceptable we certainly can introduce a global idle_cpu_mask. Where? sched.c?
> > + KERN_S390_HZ_TIMER=64, /* int: hz timer on or off */ > > Kill the S390, this seems usefull for a bunch of other architectures.
Ok, makes sense.
> > +#ifdef CONFIG_NO_IDLE_HZ > > +extern unsigned long next_timer_interrupt(void); > > +#endif > > kill the ifdef. externs don't need to be cpp'ed away.
Aye, aye, sir ;-)
blue skies, Martin
Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH Schönaicherstr. 220, D-71032 Böblingen, Telefon: 49 - (0)7031 - 16-2247 E-Mail: schwidefsky@de.ibm.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |