lkml.org 
[lkml]   [2004]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] s390 (7/9): oprofile for s390.
From
Date




Hi Christoph,
nitpicking again?

> Don't you think the name for this file is completly wrong? And a patch
> name in the comment about this file doesn't exactly help either..

Hmm, traditionally it has been irq.c but you're probably right. profile.c
is a better name for it.

> +#include <linux/smp_lock.h>
> +#include <linux/init.h>
> +#include <asm/system.h>
> +#include <asm/io.h>
> +#include <asm/pgtable.h>
> +#include <asm/delay.h>

These can indeed go.

> > + if (!((1<<smp_processor_id()) & prof_cpu_mask))
>
> shouldn't this be cpumask_t arithmetic?

Yes, it HAS to be cpumask arithmetic.

> > +//extern int irq_init(struct oprofile_operations** ops);
>
> why this?

Leftovers.

I'll fix these things right away. Thanks for the hints.

blue skies,
Martin

Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH
Schönaicherstr. 220, D-71032 Böblingen, Telefon: 49 - (0)7031 - 16-2247
E-Mail: schwidefsky@de.ibm.com


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:02    [W:0.024 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site