lkml.org 
[lkml]   [2004]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] esp: Make driver SMP-correct
Russell King wrote:
> On Fri, Dec 31, 2004 at 01:46:11AM -0800, Andrew Morton wrote:
>
>>James Nelson <james4765@verizon.net> wrote:
>>
>>>This is an attempt to make the esp serial driver SMP-correct. It also removes
>>> some cruft left over from the serial_write() conversion.
>>
>>>From a quick scan:
>>
>>- startup() does multiple sleeping allocations and request_irq() under
>> spin_lock_irqsave(). Maybe fixed by this:
>
>
> However, can you guarantee that two threads won't enter startup() at
> the same time? (that's what ASYNC_INITIALIZED is protecting the
> function against, and the corresponding shutdown() as well.)
>
> It's probably better to port ESP to the serial_core structure where
> this type of thing is already taken care of.
>

You are right. Quite a bit of work, if I am looking at it correctly, though. Any
pointers/URLs to help a newbie get their head wrapped around the process?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:09    [W:0.043 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site