Messages in this thread | | | Date | Fri, 31 Dec 2004 10:00:37 +0000 | From | Russell King <> | Subject | Re: [PATCH] esp: Make driver SMP-correct |
| |
On Fri, Dec 31, 2004 at 01:46:11AM -0800, Andrew Morton wrote: > James Nelson <james4765@verizon.net> wrote: > > > > This is an attempt to make the esp serial driver SMP-correct. It also removes > > some cruft left over from the serial_write() conversion. > > >From a quick scan: > > - startup() does multiple sleeping allocations and request_irq() under > spin_lock_irqsave(). Maybe fixed by this:
However, can you guarantee that two threads won't enter startup() at the same time? (that's what ASYNC_INITIALIZED is protecting the function against, and the corresponding shutdown() as well.)
It's probably better to port ESP to the serial_core structure where this type of thing is already taken care of.
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 PCMCIA - http://pcmcia.arm.linux.org.uk/ 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |