Messages in this thread | | | Date | Wed, 22 Dec 2004 00:27:28 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] USB: fix Scheduling while atomic warning when resuming. |
| |
David Brownell wrote: > On Tuesday 21 December 2004 8:46 pm, Jeff Garzik wrote: > >>>If that lock were dropped, what would prevent other tasks from >>>touching the hardware while it's sending RESUME signaling down >>>the bus, and thereby mucking up the resume sequence? >> >>Precisely what other tasks are active for this hardware, during resume? > > > There's no guarantee that suspend() and resume() methods > are only called during system-wide suspend and resume.
That is precisely the reason why I am concerned. If it was only during system-wide resume, the impact of the very-long mdelay() would be more difficult to notice.
You also ignored my question :)
If the PCI layer is calling the resume method for a PCI device while simultaneously calling the suspend method, that's a PCI layer problem. Similarly, If the USB layer is calling into your driver while you are resuming, something is broken and it ain't your locking.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |