Messages in this thread | | | Subject | Re: [PATCH] USB: fix Scheduling while atomic warning when resuming. | From | Benjamin Herrenschmidt <> | Date | Wed, 22 Dec 2004 12:59:28 +0100 |
| |
> If the PCI layer is calling the resume method for a PCI device while > simultaneously calling the suspend method, that's a PCI layer problem. > Similarly, If the USB layer is calling into your driver while you are > resuming, something is broken and it ain't your locking.
Actually, the later isn't broken, something may well call into the higher level USB drivers while resuming, but indeed, those shouldn't send any URB down the stack when the bus is suspended, and the EHCI driver should drop incoming URBs as well until fully resumed.
I think the lock here is only needed to protect the HCD state transitions David, no ? All we need is make sure that we don't let things get queued (or call into EHCI code path that will end up touch the HW) while suspended.
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |