lkml.org 
[lkml]   [2004]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] panic_blink and i8042 unloading
Date
Hi,

At unload i8042 sets panic_blink to 0. This will cause problems if kernel
panics later as it will just use it assuming that the pointer is correct.

Please consider the patch below that checks if panic_blink is NULL right
in panic() and sets it to no_blink instead.

--
Dmitry


===================================================================


ChangeSet@1.1956, 2004-11-06 22:53:46-05:00, dtor_core@ameritech.net
If panic_blink is NULL set it to no_blink before using.

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>


panic.c | 7 +++++--
1 files changed, 5 insertions(+), 2 deletions(-)


===================================================================



diff -Nru a/kernel/panic.c b/kernel/panic.c
--- a/kernel/panic.c 2004-11-07 01:31:36 -05:00
+++ b/kernel/panic.c 2004-11-07 01:31:36 -05:00
@@ -42,7 +42,7 @@
}

/* Returns how long it waited in ms */
-long (*panic_blink)(long time) = no_blink;
+long (*panic_blink)(long time);
EXPORT_SYMBOL(panic_blink);

/**
@@ -75,7 +75,10 @@
smp_send_stop();
#endif

- notifier_call_chain(&panic_notifier_list, 0, buf);
+ notifier_call_chain(&panic_notifier_list, 0, buf);
+
+ if (!panic_blink)
+ panic_blink = no_blink;

if (panic_timeout > 0)
{
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 14:07    [W:0.080 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site