Messages in this thread | | | From | Roland Dreier <> | Date | Mon, 22 Nov 2004 22:47:29 -0800 | Subject | Re: [PATCH][RFC/v1][4/12] Add InfiniBand SA (Subnet Administration) query support |
| |
Greg> Yeah, but a name in each file is much nicer.
Very little of the kernel seems to follow this rule right now.
Greg> One comment, the file drivers/infiniband/core/cache.c has a Greg> license that is illegal due to the contents of the file. Greg> Please change the license of the file to GPL only.
?? Can you explain this? What makes that file special?
Greg> Oh, and how about kernel-doc comments for all functions that Greg> are EXPORT_SYMBOL() marked? And for your core big Greg> structures?
I guess we'll start working on it...
- Roland - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |