lkml.org 
[lkml]   [2004]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][RFC/v1][4/12] Add InfiniBand SA (Subnet Administration) query support
On Mon, Nov 22, 2004 at 03:34:23PM -0800, Roland Dreier wrote:
> Greg> No email address of who to bug with issues?
>
> There's a patch to MAINTAINERS...

Yeah, but a name in each file is much nicer.

> Greg> What is "RESERVED"? I must be missing a previous patch
> Greg> somewhere, I currently don't see all of the series yet.
>
> It's in part 1/12: http://article.gmane.org/gmane.linux.kernel/257531
> unfortunately some people marked it as spam and it didn't get
> everywhere.

Thanks for pointing this out.

One comment, the file drivers/infiniband/core/cache.c has a license that
is illegal due to the contents of the file. Please change the license
of the file to GPL only.

Oh, and how about kernel-doc comments for all functions that are
EXPORT_SYMBOL() marked? And for your core big structures?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.060 / U:1.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site