Messages in this thread Patch in this message | | | Date | Tue, 23 Nov 2004 10:02:47 -0800 | From | Pete Zaitcev <> | Subject | ub: oops with preempt ("Sahara Workshop") |
| |
I admit that the code should be locked properly instead, but the global plan is to drop all P3 tagged printks anyway. So let it be guarded for the moment.
Signed-off-by: Pete Zaitcev <zaitcev@yahoo.com>
--- linux-2.6.10-rc2-bk8-ub/drivers/block/ub.c 2004-11-16 17:03:02.000000000 -0800 +++ linux-2.6.10-rc1-ub/drivers/block/ub.c 2004-11-07 19:01:03.000000000 -0800 @@ -1535,8 +1535,11 @@ ub_revalidate(sc); /* This is pretty much a long term P3 */ - printk(KERN_INFO "%s: device %u capacity nsec %ld bsize %u\n", - sc->name, sc->dev->devnum, sc->capacity.nsec, sc->capacity.bsize); + if (!atomic_read(&sc->poison)) { /* Cover sc->dev */ + printk(KERN_INFO "%s: device %u capacity nsec %ld bsize %u\n", + sc->name, sc->dev->devnum, + sc->capacity.nsec, sc->capacity.bsize); + } /* XXX Support sector size switching like in sr.c */ blk_queue_hardsect_size(disk->queue, sc->capacity.bsize); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |