Messages in this thread | | | Date | Sat, 20 Nov 2004 03:45:47 -0800 | From | William Lee Irwin III <> | Subject | Re: [patch] 2.6.10-rc2-mm2: OSS ac97_codec.h: #include pci.h |
| |
On Thu, Nov 18, 2004 at 04:42:20AM -0800, William Lee Irwin III wrote: >> +struct pci_dev; >> extern int ac97_tune_hardware(struct pci_dev *pdev, struct ac97_quirk *quirk, int override); >> >> #endif /* _AC97_CODEC_H_ */
On Sat, Nov 20, 2004 at 12:35:45PM +0100, Adrian Bunk wrote: > Wouldn't it be better to simply #include pci.h? > Signed-off-by: Adrian Bunk <bunk@stusta.de>
Could be; I opted for avoiding header tangling by default, but if most includers will use pci.h anyway, so be it.
-- wli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |