Messages in this thread Patch in this message | | | Date | Sat, 20 Nov 2004 12:35:45 +0100 | From | Adrian Bunk <> | Subject | [patch] 2.6.10-rc2-mm2: OSS ac97_codec.h: #include pci.h |
| |
On Thu, Nov 18, 2004 at 04:42:20AM -0800, William Lee Irwin III wrote: > On Thu, Nov 18, 2004 at 02:15:38AM -0800, Andrew Morton wrote: > > +oss-ac97-quirk-facility.patch > > Add and use device quirk lists in this OSS driver > > That patch may not actually be responsible for the warning. It's > trivially resolved regardless. > > This patch adds a forward declaration of struct pci_dev to repair the > following warning: > > In file included from sound/oss/emu10k1/hwaccess.h:38, > from sound/oss/emu10k1/cardmi.c:36: > include/linux/ac97_codec.h:337: warning: `struct pci_dev' declared inside parameter list > include/linux/ac97_codec.h:337: warning: its scope is only this definition or declaration, which is probably not what you want > > Index: mm2-2.6.10-rc2/include/linux/ac97_codec.h > =================================================================== > --- mm2-2.6.10-rc2.orig/include/linux/ac97_codec.h 2004-11-18 02:56:31.000000000 -0800 > +++ mm2-2.6.10-rc2/include/linux/ac97_codec.h 2004-11-18 03:53:05.308878784 -0800 > @@ -334,6 +334,7 @@ > int type; /* quirk type above */ > }; > > +struct pci_dev; > extern int ac97_tune_hardware(struct pci_dev *pdev, struct ac97_quirk *quirk, int override); > > #endif /* _AC97_CODEC_H_ */
Wouldn't it be better to simply #include pci.h?
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-rc2-mm2-full/include/linux/ac97_codec.h.old 2004-11-20 12:11:31.000000000 +0100 +++ linux-2.6.10-rc2-mm2-full/include/linux/ac97_codec.h 2004-11-20 12:12:26.000000000 +0100 @@ -3,6 +3,7 @@ #include <linux/types.h> #include <linux/soundcard.h> +#include <linux/pci.h> /* AC97 1.0 */ #define AC97_RESET 0x0000 //
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |