Messages in this thread Patch in this message | | | Subject | [patch 02/10] ieee/sbp2: replace schedule_timeout() with msleep() | From | janitor@sternwel ... | Date | Sat, 20 Nov 2004 03:34:29 +0100 |
| |
I would appreciate any comments from the janitor@sternweltens list. This is one (of many) cases where I made a decision about replacing
set_current_state(TASK_INTERRUPTIBLE); schedule_timeout(some_time);
with
msleep(jiffies_to_msecs(some_time));
msleep() is not exactly the same as the previous code, but I only did this replacement where I thought long delays were *desired*. If this is not the case here, then just disregard this patch.
Thanks, Nish
Description: Use msleep() instead of schedule_timeout() to guarantee desired timeout.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com> Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
---
linux-2.6.10-rc2-bk4-max/drivers/ieee1394/sbp2.c | 3 +-- 1 files changed, 1 insertion(+), 2 deletions(-)
diff -puN drivers/ieee1394/sbp2.c~msleep-drivers_ieee1394_sbp2 drivers/ieee1394/sbp2.c --- linux-2.6.10-rc2-bk4/drivers/ieee1394/sbp2.c~msleep-drivers_ieee1394_sbp2 2004-11-19 17:15:14.000000000 +0100 +++ linux-2.6.10-rc2-bk4-max/drivers/ieee1394/sbp2.c 2004-11-19 17:15:14.000000000 +0100 @@ -902,8 +902,7 @@ alloc_fail: * connected to the sbp2 device being removed. That host would * have a certain amount of time to relogin before the sbp2 device * allows someone else to login instead. One second makes sense. */ - set_current_state(TASK_INTERRUPTIBLE); - schedule_timeout(HZ); + msleep(1000); /* * Login to the sbp-2 device _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |