Messages in this thread | | | Date | Thu, 18 Nov 2004 23:19:43 -0800 | From | Chris Wright <> | Subject | Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET |
| |
* Ross Kendall Axe (ross.axe@blueyonder.co.uk) wrote: > Taking this idea further, couldn't we split unix_dgram_sendmsg into 2 > functions, do_unix_dgram_sendmsg and do_unix_connectionless_sendmsg (and > similarly for unix_stream_sendmsg), then all we'd need is: > > <pseudocode> > static int do_unix_dgram_sendmsg(...); > static int do_unix_stream_sendmsg(...); > static int do_unix_connectionless_sendmsg(...); > static int do_unix_connectional_sendmsg(...);
We could probably break it down to better functions and helpers, but I'm not sure that's quite the breakdown. That looks to me like an indirect way to pass a flag which is already encoded in the ops and sk_type. At anyrate, for 2.6.10 the changes should be small and obvious. Better refactoring should be left for 2.6.11.
thanks, -chris -- Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |