Messages in this thread | | | Date | Thu, 18 Nov 2004 09:07:06 -0800 | From | Chris Wright <> | Subject | Re: [PATCH] linux 2.9.10-rc1: Fix oops in unix_dgram_sendmsg when using SELinux and SOCK_SEQPACKET |
| |
* James Morris (jmorris@redhat.com) wrote: > On Thu, 18 Nov 2004, Chris Wright wrote: > > > Why not make a unix_seq_sendmsg, which is a very small wrapper? > > Good idea, patch forthcoming. > > > Does the above stop the other issue? My laptop died, so I'm not able to > > test ATM. > > No, it seems to be caused when addrlen in sendto() is non-zero, causing > unix_find_other() to be called instead of unix_peer_get(), which is > screwing up reference counts.
Right, but the snippet I posted guards against that I think. It forces unix_peer_get() in dgram_sendmsg.
> As for MSG_EOR, apart from the generic socket code, nothing is being done. > This would be a separate issue.
Yup, just noting the bits that looked broken to me.
thanks, -chris -- Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |