Messages in this thread | | | From | David Howells <> | Subject | fork pagesize patch | Date | Tue, 16 Nov 2004 15:38:11 +0000 |
| |
Hi Linus,
You seem to have turned:
+#if THREAD_SIZE >= PAGE_SIZE max_threads = mempages / (THREAD_SIZE/PAGE_SIZE) / 8; +#else + max_threads = mempages / 8; +#endif +
Into:
if (THREAD_SIZE >= PAGE_SIZE) max_threads = mempages / (THREAD_SIZE/PAGE_SIZE) / 8; else max_threads = mempages / 8;
Please don't do that. What you've done causes a divide-by-zero error to be emitted by the compiler if PAGE_SIZE > THREAD_SIZE. That's why I used the preprocessor in the first place.
On FRV arch the minimum page size the MMU permits (when there is an MMU) is 16KB; however, that's rather a lot of stack space for the kernel, so I only allocate half that.
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |