Messages in this thread Patch in this message | | | Date | Sun, 14 Nov 2004 03:37:28 +0000 | From | Daniel Drake <> | Subject | [PATCH 2/3] raw1394: __copy_from_user check |
| |
Add a check for the return value of __copy_to_user Depends on the previous whitespace fix patch.
Signed-off-by: Daniel Drake <dsd@gentoo.org> --- linux/drivers/ieee1394/raw1394.c.orig 2004-11-14 03:02:30.000000000 +0000 +++ linux/drivers/ieee1394/raw1394.c 2004-11-14 03:12:12.928827600 +0000 @@ -447,9 +447,12 @@ static ssize_t raw1394_read(struct file req->req.error = RAW1394_ERROR_MEMFAULT; } } - __copy_to_user(buffer, &req->req, sizeof(req->req)); free_pending_request(req); + + if (__copy_to_user(buffer, &req->req, sizeof(req->req))) + return -EFAULT; + return sizeof(struct raw1394_request); } | |