lkml.org 
[lkml]   [2004]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] __init in mm/slab.c
 From the bk commit log:

>ChangeSet 1.2132, 2004/11/13 20:59:55-08:00, Andries.Brouwer@cwi.nl
>
> [PATCH] __init in mm/slab.c
>
> The below removes an __initdata
> (for initarray_generic that is referenced in non-init code).
>
>
I think the patch is wrong and should be reverted: initarray_generic is
referenced, but never used:

> if (g_cpucache_up == NONE) {
> /* Note: the first kmem_cache_create must create
> * the cache that's used by kmalloc(24), otherwise
> * the creation of further caches will BUG().
> */
> cachep->array[smp_processor_id()] = &initarray_generic.cache;
> g_cpucache_up = PARTIAL;
> } else {
> cachep->array[smp_processor_id()] = kmalloc(sizeof(struct
> arraycache_init),GFP_KERNEL);
> }

g_cpucache_up is NONE during bootstrap and FULL after boot. Thus the
initarray is never accessed after boot.

Andries, why did you propose this change? Does the current code trigger
an automatic test?

--
Manfred
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:08    [W:0.049 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site