lkml.org 
[lkml]   [2004]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Suspected bug infilesystems (UFS,ADFS,BEFS,BFS,ReiserFS) related to sector_t being unsigned, advice requested
Oleg Drokin wrote:

>Hello!
>
>On Wed, Jan 07, 2004 at 12:26:09PM +0300, Hans Reiser wrote:
>
>
>>>As for why gcc is finding this, but scripts (e.g. smatch) do not is because
>>>scripts generally know nothing about variable types, so they cannot tell
>>>this comparison was always false (and since gcc can do this for long time
>>>already, there is no point in implementing it in scripts anyway).
>>>
>>>
>>can we get gcc to issue us a warning? there might be other stuff
>>lurking around also....
>>
>>
>
>If you add -W switch to CFLAGS, you'd get A LOT of more warnings.
>Also just reading manpage on gcc around description of that flag will
>give you a list of options to individually turn on certain check types.
>Also gcc 3.3 have this sort of " unsigned < 0 | unsigned > 0" checks on by
>default, I think.
>
>Bye,
> Oleg
>
>
>
>
Sigh, this means that not one member of our team bothered to compile
with -W and cleanup things that were found? Sad. This is what happens
when project leaders like me spend more of their time on funding
proposals than code tweaking.....

Elena, please do so, for both V3 and V4, and send a proposed patch to
cleanup what gets complained of.

--
Hans


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:59    [W:0.088 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site