Messages in this thread | | | Date | Tue, 13 Jan 2004 17:26:05 +0100 | From | Adrian Bunk <> | Subject | Re: Suspected bug infilesystems (UFS,ADFS,BEFS,BFS,ReiserFS) related to sector_t being unsigned, advice requested |
| |
On Wed, Jan 07, 2004 at 12:01:13PM +0200, Oleg Drokin wrote: > Hello! > > On Wed, Jan 07, 2004 at 12:26:09PM +0300, Hans Reiser wrote: > > >As for why gcc is finding this, but scripts (e.g. smatch) do not is because > > >scripts generally know nothing about variable types, so they cannot tell > > >this comparison was always false (and since gcc can do this for long time > > >already, there is no point in implementing it in scripts anyway). > > can we get gcc to issue us a warning? there might be other stuff > > lurking around also.... > > If you add -W switch to CFLAGS, you'd get A LOT of more warnings. > Also just reading manpage on gcc around description of that flag will > give you a list of options to individually turn on certain check types. > Also gcc 3.3 have this sort of " unsigned < 0 | unsigned > 0" checks on by > default, I think.
IIRC this was only in prerelease versions of gcc 3.3 (including one SuSE ships). For released version of gcc you need -Wsign-compare.
> Bye, > Oleg
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |