lkml.org 
[lkml]   [2003]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [CHECKER] 32 Memory Leaks on Error Paths


On Wed, 24 Sep 2003, Pete Zaitcev wrote:

> > Date: Tue, 23 Sep 2003 13:15:15 -0700
> > From: Chris Wright <chrisw@osdl.org>
>
> > --- 1.38/sound/oss/ymfpci.c Tue Aug 26 09:25:41 2003
> > +++ edited/sound/oss/ymfpci.c Tue Sep 23 12:42:45 2003
> > @@ -2638,6 +2638,7 @@
> > out_free:
> > if (codec->ac97_codec[0])
> > ac97_release_codec(codec->ac97_codec[0]);
> > + kfree(codec);
> > return -ENODEV;
> > }
>
> Someone was savaging sound code, adding these bugs.
> For 2.6, the above patch is probably ok; it's immaterial,
> because ALSA won long ago.
>
> A patch for 2.4 to undo the damage is attached.

Pete,

So let me see if I get it right: The above "+ kfree(codec)" addition caused the bug?



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:49    [W:0.039 / U:1.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site