lkml.org 
[lkml]   [2003]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [CHECKER] 32 Memory Leaks on Error Paths
From
Date
On Mer, 2003-09-24 at 05:13, Pete Zaitcev wrote: 
> - spin_lock(&codec->ac97_lock);
> + down(&unit->ac97_lock);
> /* XXX Do make use of dev->id */
> - ymfpci_codec_ready(codec, 0, 0);

This breaks ac97 locking and should not be applied. The core ac97
code is called some times with interrupts disabled. That is unavoidable.

The only change that is relevant is the kfree

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.052 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site