Messages in this thread | | | Date | Mon, 04 Aug 2003 00:31:17 -0500 | From | Steve French <> | Subject | Re: do_div considered harmful |
| |
I have made a change to fix this in fs/cifs/inode.c and a similar problem in fs/cifs/file.c (and a change to fs/cifs/cifsfs.c to better match the blocksize bits and blocksize default). It is (version 0.8.7 of the cifs vfs) in bk://cifs.bkbits.net/linux-2.5cifs and I am testing it now.
>> Similarly, I find in fs/cifs/inode.c> >> inode->i_blocks = do_div(findData.NumOfBytes, inode->i_blksize); > >This should be > > int blocksize = 1 << inode->i_blkbits; > > inode->i_blocks = (findData.NumOfBytes + blocksize - 1) > >> inode->i_blkbits;
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |