lkml.org 
[lkml]   [2003]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH] efivars update
Date
From
Matt,

> Move the unlock up above the status test, else you return while
> holding the lock on failure.

Ouch. Thanks...

> level on printk please.

Fixed.

> Might as well just force the deletion by setting Attributes=0 or
> DataSize=0 or both. Less chance for userspace error.

Good idea.

> Please kill this chunk. I shouldn't have had it there in the first
> place. :-)
>
> Looks great to me! Thanks again.

Sure thing. Updated patch attached....

matt
[unhandled content-type:application/octet-stream]
\
 
 \ /
  Last update: 2005-03-22 13:48    [W:0.022 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site