Messages in this thread | | | Date | Sun, 24 Aug 2003 18:31:44 +0200 | From | Manfred Spraul <> | Subject | Re: [PATCH 2.6.0-test4][NET] ni5010.c: remove cli/sti |
| |
Vinay wrote:
>drivers/net/ni5010.c: >This patch replaces cli/sti with spinlocks. Compiles fine though >untested. > > I don't have the hardware either, but the patch seems to be wrong: The cli() call was in hardware_send_packet(). I assume that this function should be synchronized against concurrent interrupts - both functions access the hardware. Due to the dev_xmit_lock, the networking core already guarantees that hardware_send_packet is never reentered. cli() provided protection against concurrent interrupts on other cpus, spin_lock_irqsave() doesn't.
Could you add a spin_lock()/spin_unlock() into ni5010_interrupt?
-- Manfred
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |