Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | "Krishnakumar. R" <> | Subject | [PATCH-2.6.0-test4-bk1][stallion.c]Remaining task queue to work queue conversion. | Date | Sun, 24 Aug 2003 18:18:37 +0530 |
| |
Dear Linus and all,
Somewhere in the transition of task queue to the work queue, in stallion.c, some of the schedule_task were left out from being converted to schedule_work. The following patch solves the problem.
Without this the drivers/char/stallion.c cannot be compiled as part of the kernel (make bzImage).
Please do apply!
Regards KK
============================ The following is the patch:
--- linux-2.6.0-test4-bk1/drivers/char/stallion.orig.c 2003-08-23 05:28:12.000000000 +0530 +++ linux-2.6.0-test4-bk1/drivers/char/stallion.c 2003-08-24 18:09:23.000000000 +0530 @@ -4234,7 +4234,7 @@ misr = inb(ioaddr + EREG_DATA); if (misr & MISR_DCD) { set_bit(ASYI_DCDCHANGE, &portp->istate); - schedule_task(&portp->tqueue); + schedule_work(&portp->tqueue); portp->stats.modem++; } @@ -5031,7 +5031,7 @@ if ((len == 0) || ((len < STL_TXBUFLOW) && (test_bit(ASYI_TXLOW, &portp->istate) == 0))) { set_bit(ASYI_TXLOW, &portp->istate); - schedule_task(&portp->tqueue); + schedule_work(&portp->tqueue); } if (len == 0) { @@ -5248,7 +5248,7 @@ ipr = stl_sc26198getreg(portp, IPR); if (ipr & IPR_DCDCHANGE) { set_bit(ASYI_DCDCHANGE, &portp->istate); - schedule_task(&portp->tqueue); + schedule_work(&portp->tqueue); portp->stats.modem++; } break;
=============================== diffstat output: stallion.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) =============================== Compiliation errors removed: drivers/char/stallion.c: In function `stl_cd1400mdmisr': drivers/char/stallion.c:4237: warning: implicit declaration of function `schedule_task' ================================ Linking errors removed: drivers/built-in.o(.text+0x400ae): In function `stl_cd1400mdmisr': : undefined reference to `schedule_task' drivers/built-in.o(.text+0x41218): In function `stl_sc26198txisr': : undefined reference to `schedule_task' drivers/built-in.o(.text+0x41699): In function `stl_sc26198otherisr': : undefined reference to `schedule_task' make: *** [.tmp_vmlinux1] Error 1 ================================= - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |