Messages in this thread | ![/](/images/icornerl.gif) | | From | "Petr Vandrovec" <> | Date | Mon, 11 Aug 2003 20:33:13 +0200 | Subject | Re: [PATCH] Remove useless assertions from reiserfs |
| |
On 11 Aug 03 at 14:00, Valdis.Kletnieks@vt.edu wrote: > On Mon, 11 Aug 2003 13:45:30 EDT, Jeff Garzik said: > > Why are these useless? > > > > if (len >= 12) > > > { > > > //assert(len < 16); > > > if (len >= 16) > > > BUG(); > > > > Seems like a valid check to me... > > Just before that, there's code: > > while(len >= 16) > { > ... > len -= 16; > } > > So if that ever exits with a len >=16, we have a SERIOUS problem with > either the compiler or the hardware - as such, that "if (..) BUG" is dead code. > Similarly for the other checks.
I always thought that assertions are just for that - if you can hit them without some unexpected event/bug, you have a SERIOUS problem. Petr Vandrovec
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |