Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 04 Jul 2003 09:44:08 -0400 | From | Jeff Garzik <> | Subject | Re: [PATCH] Re: VIA PCI IRQ router bug fix |
| |
Arjan van de Ven wrote: >> >> static int pirq_via_set(struct pci_dev *router, struct pci_dev *dev, int pirq, int irq) >> { >>- write_config_nybble(router, 0x55, pirq, irq); >>+ write_config_nybble(router, 0x55, pirq == 4 ? 5 : pirq, irq); >> return 1; >> } > > > > you missed the > >>+ return (x >> 4); > > in the original patch... so your code is NOT identical.
Look at read_config_nybble...
return (nr & 1) ? (x >> 4) : (x & 0xf);
Can you spell out which part is different? I don't see it.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |