lkml.org 
[lkml]   [2003]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Re: VIA PCI IRQ router bug fix
Arjan van de Ven wrote:
>>
>> static int pirq_via_set(struct pci_dev *router, struct pci_dev *dev, int pirq, int irq)
>> {
>>- write_config_nybble(router, 0x55, pirq, irq);
>>+ write_config_nybble(router, 0x55, pirq == 4 ? 5 : pirq, irq);
>> return 1;
>> }
>
>
>
> you missed the
>
>>+ return (x >> 4);
>
> in the original patch... so your code is NOT identical.

Look at read_config_nybble...

return (nr & 1) ? (x >> 4) : (x & 0xf);

Can you spell out which part is different? I don't see it.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:46    [W:0.179 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site