lkml.org 
[lkml]   [2003]   [Jun]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PCI: move pci_present() into drivers/pci/search.c
Linux Kernel Mailing List wrote:
> ChangeSet 1.1317, 2003/06/05 12:04:33-07:00, greg@kroah.com
>
> [PATCH] PCI: move pci_present() into drivers/pci/search.c
>
> This will let not have to export the pci_devices variable.


pci_present() should be killed. It's left over from 2.0 or 1.2 days,
and has no meaning anymore.

The old-kernel use was to determine if a PCI bus. Drivers had to check
if a PCI bus was present, before probing for a PCI device using the
old-old find-by-slot-and-busid method of PCI bus probing. As the
now-old method of PCI bus probing (pci_find_device) and the current PCI
API both provide correct behavior when no PCI bus is present,
pci_present() itself no longer has any meaning and is entirely redundant.

At the very least, we should use the gcc "deprecated" attribute on
pci_present definitions, both normal and no-op.

IMO pci_present should go before 2.6.0... it's lived long enough.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:36    [W:0.037 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site