Messages in this thread Patch in this message | | | Date | Tue, 24 Jun 2003 19:22:55 +0200 | From | Adrian Bunk <> | Subject | 2.5.73: eth1394.c: ptask might be used uninitialized |
| |
In 2.5.73, gcc complains as follows:
<-- snip -->
... CC drivers/ieee1394/eth1394.o ... drivers/ieee1394/eth1394.c:1424: warning: `ptask' might be used uninitialized in this function ...
<-- snip -->
It seems something like the patch below might be needed (I didn't check for 100% correctness, but it shows what might be needed to fix it).
cu Adrian
--- linux-2.5.73-not-full/drivers/ieee1394/eth1394.c.old 2003-06-23 23:11:01.000000000 +0200 +++ linux-2.5.73-not-full/drivers/ieee1394/eth1394.c 2003-06-23 23:11:25.000000000 +0200 @@ -1427,7 +1427,7 @@ if (skb_is_nonlinear(skb)) { ret = skb_linearize(skb, kmflags); if(ret) - goto fail; + goto out; } ptask = kmem_cache_alloc(packet_task_cache, kmflags); @@ -1555,6 +1555,7 @@ ether1394_free_packet(ptask->packet); if(ptask) kmem_cache_free(packet_task_cache, ptask); +out: if(skb != NULL) { dev_kfree_skb(skb); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |