Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Tue, 24 Jun 2003 19:19:26 +0200 | From | Adrian Bunk <> | Subject | [2.5 patch] small cleanups for amd-k8-agp.c |
| |
Hi Dave,
the patch below does the following trivial cleanups to drivers/char/agp/amd-k8-agp.c: - postfix three constants with ULL - remove a variable that isn't needed
Please apply Adrian
--- linux-2.5.73-not-full/drivers/char/agp/amd-k8-agp.c.old 2003-06-23 22:26:27.000000000 +0200 +++ linux-2.5.73-not-full/drivers/char/agp/amd-k8-agp.c 2003-06-23 22:27:21.000000000 +0200 @@ -47,7 +47,6 @@ static int x86_64_insert_memory(struct agp_memory *mem, off_t pg_start, int type) { int i, j, num_entries; - long tmp; u32 pte; u64 addr; @@ -78,10 +77,9 @@ for (i = 0, j = pg_start; i < mem->page_count; i++, j++) { addr = agp_bridge->driver->mask_memory(mem->memory[i], mem->type); - tmp = addr; - BUG_ON(tmp & 0xffffff0000000ffc); - pte = (tmp & 0x000000ff00000000) >> 28; - pte |=(tmp & 0x00000000fffff000); + BUG_ON(addr & 0xffffff0000000ffcULL); + pte = (addr & 0x000000ff00000000ULL) >> 28; + pte |=(addr & 0x00000000fffff000ULL); pte |= 1<<1|1<<0; agp_bridge->gatt_table[j] = pte; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |