Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 13 Jun 2003 19:29:18 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH] Consolidate Kconfigs for binfmts |
| |
On Fri, Jun 13, 2003 at 03:24:34PM +0200, Geert Uytterhoeven wrote: > On Fri, 13 Jun 2003, Matthew Wilcox wrote: > > +config BINFMT_MISC > > + tristate "Kernel support for MISC binaries" > > + ---help--- > > > + You must say Y to "/proc file system support" (CONFIG_PROC_FS) to > > + use this part of the kernel. > > You don't want to add an explicit dependency?
I was thinking about this and decided to check it out. It's actually not true any more. binfmt_misc was converted (back in 2.4) to be its own filesystem. If binfmt_misc is compiled in or as a module (?!), procfs creates somewhere for you to mount it (/proc/sys/fs/binfmt_misc) but there's no need to mount it there.
I note that if you have CONFIG_SYSCTL=n, it will actually silently fail to create this directory.
#ifdef CONFIG_SYSCTL proc_sys_root = proc_mkdir("sys", 0); #endif #if defined(CONFIG_BINFMT_MISC) || defined(CONFIG_BINFMT_MISC_MODULE) proc_mkdir("sys/fs", 0); proc_mkdir("sys/fs/binfmt_misc", 0); #endif
So I guess I'll remove the bit from the helptext about procfs and substitute some better words instead. Maybe I'll update Documentation/binfmt_misc too.
-- "It's not Hollywood. War is real, war is primarily not about defeat or victory, it is about death. I've seen thousands and thousands of dead bodies. Do you think I want to have an academic debate on this subject?" -- Robert Fisk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |