lkml.org 
[lkml]   [2003]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xirc2ps_cs irq return fix
Linux Kernel Mailing List wrote:
> diff -Nru a/drivers/net/pcmcia/xirc2ps_cs.c b/drivers/net/pcmcia/xirc2ps_cs.c
> --- a/drivers/net/pcmcia/xirc2ps_cs.c Sun May 25 16:18:34 2003
> +++ b/drivers/net/pcmcia/xirc2ps_cs.c Sun May 25 16:18:34 2003
> if (!netif_device_present(dev))
> - return IRQ_NONE;
> + return IRQ_HANDLED;

As I mentioned in the thread, this piece of code is obviously wrong.

Think about how scalable this fix is?? Do you really want to crap up
all pcmcia drivers with this silly -- and wrong -- check?

IIRC the pcmcia layer or new irqreturn_t was blamed for the problem.
Come on. Linux mantra is -against- papering over bugs.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:35    [W:0.052 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site