Messages in this thread | | | From | Duncan Sands <> | Subject | Re: [linux-usb-devel] [PATCH] USB speedtouch: don't open a connection if no firmware | Date | Tue, 8 Apr 2003 22:22:10 +0200 |
| |
> > + udsl_fire_receivers (instance); > > > > dbg ("udsl_atm_open successful"); > > > > + MOD_INC_USE_COUNT; > > + > > return 0; > > } > > Any way you can convert this driver to not use MOD_INC_USE_COUNT, as > it's racy and not really supported anymore? But if you _really_ have to > use it, you need to call it at the first possible chance to make any > race window smaller.
Hi Greg, I'm waiting on the fixes to the ATM layer (coming soon to a kernel near you). As for the position of MOD_INC_USE_COUNT, did you ever hear of anyone getting bitten by a race like this? If it makes you feel better, I will move it up, probably just before I take the semaphore (since that is the first place we can sleep). I will do it tomorrow, OK?
All the best,
Duncan. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |