lkml.org 
[lkml]   [2003]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [linux-usb-devel] [PATCH] USB speedtouch: don't open a connection if no firmware
Date
> > +	udsl_fire_receivers (instance);
> >
> > dbg ("udsl_atm_open successful");
> >
> > + MOD_INC_USE_COUNT;
> > +
> > return 0;
> > }
>
> Any way you can convert this driver to not use MOD_INC_USE_COUNT, as
> it's racy and not really supported anymore? But if you _really_ have to
> use it, you need to call it at the first possible chance to make any
> race window smaller.

Hi Greg, I'm waiting on the fixes to the ATM layer (coming soon to a kernel
near you). As for the position of MOD_INC_USE_COUNT, did you ever hear
of anyone getting bitten by a race like this? If it makes you feel better, I
will move it up, probably just before I take the semaphore (since that is the
first place we can sleep). I will do it tomorrow, OK?

All the best,

Duncan.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:34    [W:0.021 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site