Messages in this thread | | | Date | Tue, 8 Apr 2003 13:12:40 -0700 | From | Greg KH <> | Subject | Re: [linux-usb-devel] [PATCH] USB speedtouch: don't open a connection if no firmware |
| |
On Tue, Apr 08, 2003 at 09:26:43AM +0200, Duncan Sands wrote: > @@ -967,13 +969,12 @@ > > dbg ("Allocated new SARLib vcc 0x%p with vpi %d vci %d", new, vpi, vci); > > - MOD_INC_USE_COUNT; > - > - if (instance->firmware_loaded) > - udsl_fire_receivers (instance); > + udsl_fire_receivers (instance); > > dbg ("udsl_atm_open successful"); > > + MOD_INC_USE_COUNT; > + > return 0; > } >
Any way you can convert this driver to not use MOD_INC_USE_COUNT, as it's racy and not really supported anymore? But if you _really_ have to use it, you need to call it at the first possible chance to make any race window smaller.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |