Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: Re: [PATCH][RESEND] socket interface for IPMI against 2.5.66-bk | From | Louis Zhuang <> | Date | 07 Apr 2003 09:26:40 +0800 |
| |
On Fri, 2003-04-04 at 22:55, Corey Minyard wrote: > I've merged this in, but I made some adjustments: > > * I added a copyright to include/net/ipmi.h (just copied from > net/ipmi/af_ipmi.c) Just curious, should we add copyright even when I have announced it by 'MODULE_LICENSE("GPL")'? I dislike too many leagal text in code... > * I added usage comments to include/net/ipmi.h > * I modified the ioctls to return EFAULT on a bad user address. > * I modified SIOCIPMIGETEVENT to take a pointer to an integer, not > an integer. That's the way ioctls work, they always take a pointer, > even though it sucks, IMHO. > > I also adapted it to the 2.4 kernel. > > I'll put out an experimental patch for this sometime soon (with a bunch > of other stuff). I also have SMIC and full ACPI support as part of it, > and I'm waiting for them. > > - -Corey
-- Yours truly, Louis Zhuang --------------- My words are my own...
Fault Injection Test Harness Project BK tree: http://fault-injection.bkbits.net/linux-2.5 Home Page: http://sf.net/projects/fault-injection
Open HPI Project Home Page: http://sf.net/projects/openhpi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |