Messages in this thread | | | From | Andries.Brouwer@cwi ... | Date | Sun, 20 Apr 2003 22:34:38 +0200 (MEST) | Subject | Re: [PATCH] new system call mknod64 |
| |
From: Christoph Hellwig <hch@infradead.org>
On Sun, Apr 20, 2003 at 08:39:32PM +0200, Andries.Brouwer@cwi.nl wrote: > Change the type of the mknod arg from dev_t to unsigned int. > Add (for i386) mknod64.
Please make the argument for mknod/mknod64 __u32/__u64. And I don't think adding the syscall makes sense before the internal dev_t representation has changed.
Yes, there is a dozen rather uninteresting patches that can be applied any moment. But a new system call is more important, so I show it in public at some earlier stage, so that Linus and others, like you, can comment.
Yesterday or the day before Linus preferred __u32 etc for this loopinfo64 ioctl, so I did it that way. Here, since mknod is a traditional Unix system call, I am still inclined to prefer (unsigned) int above __u32. Of course it doesn't matter much.
Andries - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |