Messages in this thread | | | Subject | Re: [PATCH] reduce stack in cdrom/optcd.c | From | Arjan van de Ven <> | Date | 22 Mar 2003 21:19:59 +0100 |
| |
On Sat, 2003-03-22 at 21:43, Alan Cox wrote: > On Sat, 2003-03-22 at 06:51, Randy.Dunlap wrote: > > Hi, > > > > This reduces stack usage in drivers/cdrom/optcd.c by > > dynamically allocating a large (> 2 KB) buffer. > > > > Patch is to 2.5.65. Please apply. > > This loosk broken. You are using GFP_KERNEL memory allocations on the > read path of a block device. What happens if the allocation fails > because we need memory
it's unlikely that you have your swap on the cdrom ;) [unhandled content-type:application/pgp-signature] | |