lkml.org 
[lkml]   [2003]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] reduce stack in cdrom/optcd.c
From
Date
On Sat, 2003-03-22 at 06:51, Randy.Dunlap wrote:
> Hi,
>
> This reduces stack usage in drivers/cdrom/optcd.c by
> dynamically allocating a large (> 2 KB) buffer.
>
> Patch is to 2.5.65. Please apply.

This loosk broken. You are using GFP_KERNEL memory allocations on the
read path of a block device. What happens if the allocation fails
because we need memory

Surely that buffer needs to be allocated once at open and freed on close
?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:34    [W:0.035 / U:0.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site