Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH] reduce stack in cdrom/optcd.c | From | Alan Cox <> | Date | 22 Mar 2003 20:43:19 +0000 |
| |
On Sat, 2003-03-22 at 06:51, Randy.Dunlap wrote: > Hi, > > This reduces stack usage in drivers/cdrom/optcd.c by > dynamically allocating a large (> 2 KB) buffer. > > Patch is to 2.5.65. Please apply.
This loosk broken. You are using GFP_KERNEL memory allocations on the read path of a block device. What happens if the allocation fails because we need memory
Surely that buffer needs to be allocated once at open and freed on close ?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |