Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Thu, 20 Feb 2003 23:55:19 +0200 | From | Faik Uygur <> | Subject | [PATCH] 2.5.62: /proc/ide/via reads return incomplete data, Bug #374 |
| |
This patch fixes the incomplete data return problem of /proc/ide/via and addresses Bug #374 of Bugzilla.
When the number of consecutive read bytes are smaller than the total data in via_get_info(), the second read() returns 0.
--- linux-2.5.62-vanilla/drivers/ide/pci/via82cxxx.c Thu Feb 20 18:51:52 2003 +++ linux-2.5.62/drivers/ide/pci/via82cxxx.c Thu Feb 20 23:09:23 2003 @@ -145,6 +145,7 @@ uen[4], udma[4], umul[4], active8b[4], recover8b[4]; struct pci_dev *dev = bmide_dev; unsigned int v, u, i; + int len; u16 c, w; u8 t, x; char *p = buffer; @@ -274,7 +275,10 @@ speed[i] / 1000, speed[i] / 100 % 10);
/* hoping it is less than 4K... */ - return p - buffer; + len = (p - buffer) - offset; + *addr = buffer + offset; + + return len > count ? count : len; }
#endif /* DISPLAY_VIA_TIMINGS && CONFIG_PROC_FS */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |