Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH] add new DMA_ADDR_T_SIZE define | From | James Bottomley <> | Date | 19 Feb 2003 13:11:07 -0500 |
| |
> 3. use run-time checks all over the place, of the > "sizeof(dma_addr_t)==sizeof(u64)" kind, which adds unnecessary > overhead to > all platforms.
Actually, these aren't technically run time checks. Although the cpp can't be used for sizeof(), the compiler (at least gcc) does seem to have enough sense to optimise away if(..) branches it has enough information to know won't be taken at compile time.
As long as this optimisation works, I think the if(sizeof(..)) checks are fine for this.
James
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |