Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sat, 15 Feb 2003 11:56:54 -0500 (EST) | From | Zwane Mwaikambo <> | Subject | Re: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390 |
| |
On Sat, 15 Feb 2003, Ulrich Weigand wrote:
> Hmm. I think this code still has a problem. If the caller > passes in a mask containing bits for offline CPUs, those will > be counted here
It would be a bug in the caller, this is a primitive really. If the caller is calling this with random bitmasks they are probably making errors elsewhere too. This is also the behaviour of the Alpha version, which has been around before this patch.
> > + num_cpus = hweight32(mask); > > but there will be no external interrupt generated for those, > and thus this loop > > > + while (atomic_read(&data.started) != num_cpus) > > will never terminate ...
The following cpu_online call only goes as far as avoiding IPI'ing to nonexistent cpus, anything more would be spoonfeeding the caller, i prefer garbage in, garbage out.
for (i = 0; i < NR_CPUS; i++) { if (cpu_online(i) && ((1UL << i) & mask)) smp_ext_bitcall(i, ec_call_function); }
Thanks, Zwane -- function.linuxpower.ca - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |