Messages in this thread | | | From | Ulrich Weigand <> | Subject | Re: [PATCH][2.5][8/14] smp_call_function_on_cpu - s390 | Date | Sat, 15 Feb 2003 17:04:04 +0100 (MET) |
| |
Zwane Mwaikambo wrote:
> On Sat, 15 Feb 2003, Ulrich Weigand wrote: > > That's still '&&' instead of '&'. > > *sigh*
Hmm. I think this code still has a problem. If the caller passes in a mask containing bits for offline CPUs, those will be counted here
> + num_cpus = hweight32(mask);
but there will be no external interrupt generated for those, and thus this loop
> + while (atomic_read(&data.started) != num_cpus)
will never terminate ...
Bye, Ulrich
-- Dr. Ulrich Weigand weigand@informatik.uni-erlangen.de - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |