lkml.org 
[lkml]   [2003]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: reiser4 breaks vmware
From
Date
Nikita Danilov <Nikita@Namesys.COM> writes:

> Exactly. I included it into core.diff by mistake.
> Revert it: http://www.namesys.com/snapshots/2003.12.23/broken-out/do_mmap2-fix.diff.patch

There seem to be some other unnecessary patches in there, like
init_fixmap_vma.diff.patch. I cannot imagine why a file system should
need to change that. Same with spinlock-owner.diff.patch. Is that
really needed? If yes porting it to all architectures will be a lot of
work.

I would suggest separating your debug patches, like page-owner.diff.patch

And your webserver is misconfigured: I thinks READ.ME is a troff
document.

The other changes look reasonable, although a lot of the EXPORT_SYMBOLs
should be probably EXPORT_SYMBOL_GPL and carry some more comments about
their purpose.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:59    [W:0.032 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site