Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: reiser4 breaks vmware | From | Andi Kleen <> | Date | 24 Dec 2003 23:15:45 +0100 |
| |
Nikita Danilov <Nikita@Namesys.COM> writes:
> Exactly. I included it into core.diff by mistake. > Revert it: http://www.namesys.com/snapshots/2003.12.23/broken-out/do_mmap2-fix.diff.patch
There seem to be some other unnecessary patches in there, like init_fixmap_vma.diff.patch. I cannot imagine why a file system should need to change that. Same with spinlock-owner.diff.patch. Is that really needed? If yes porting it to all architectures will be a lot of work.
I would suggest separating your debug patches, like page-owner.diff.patch
And your webserver is misconfigured: I thinks READ.ME is a troff document.
The other changes look reasonable, although a lot of the EXPORT_SYMBOLs should be probably EXPORT_SYMBOL_GPL and carry some more comments about their purpose.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |