Messages in this thread | ![/](/images/icornerl.gif) | | Date | Sun, 14 Dec 2003 12:45:34 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [patch] Re: Problem with exiting threads under NPTL |
| |
On Sun, 14 Dec 2003, Linus Torvalds wrote: > > That code looks fragile as hell. I think you fixed a bug and it might be > the absolutely proper fix, but I'd be happier about it if it was more > obvious what the rules are and _why_ that is the only case that matters..
Btw, on another note: to avoid the appearance of recursion, I'd prefer a
p = leader; goto top;
instead of a "release_task(leader);".
I realize that the recursion should be just one deep (the leader of the leader is itself, and that will stop the thing from going further), but it looks trivial to avoid it, and any automated source checking tool would be confused by the apparent recursion.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |